Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use integers #1620

Merged
merged 1 commit into from
Jan 17, 2025
Merged

use integers #1620

merged 1 commit into from
Jan 17, 2025

Conversation

kkraune
Copy link
Member

@kkraune kkraune commented Jan 17, 2025

  • avoid ERROR: 'float' object cannot be interpreted as an integer

CC @thomasht86 this started failing auto testing, could be the python version was bumped / something made this stricter?

@kkraune
use integers
700b9ce 
- avoid ERROR: 'float' object cannot be interpreted as an integer
@kkraune kkraune merged commit 8a00708 into master Jan 17, 2025
2 of 3 checks passed
@kkraune kkraune deleted the kkraune/bugfix-float branch January 17, 2025 10:24
@thomasht86
Copy link
Contributor

  • avoid ERROR: 'float' object cannot be interpreted as an integer

CC @thomasht86 this started failing auto testing, could be the python version was bumped / something made this stricter?

Yep, no python-version specified, and ubuntu-latest, was recently updated to use Python 3.12, so that's probably why.
We probably should specify this in our reusable action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkraune @thomasht86