Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_FanOutBuild should depend on BeforeBuild and AfterBuild #69

Closed
alexrp opened this issue Jan 23, 2023 · 1 comment
Closed

_FanOutBuild should depend on BeforeBuild and AfterBuild #69

alexrp opened this issue Jan 23, 2023 · 1 comment
Labels
area: sdk Issues related to the MSBuild SDK.
Milestone

Comments

@alexrp
Copy link
Member

alexrp commented Jan 23, 2023

It's fairly surprising that making a target run before/after these extension points makes it not trigger at all for the top-level build. #68 should be addressed together with this so that such an extension target knows whether it's running in the top-level build.

@alexrp alexrp added type: feature state: approved Enhancements and tasks that have been approved. area: sdk Issues related to the MSBuild SDK. labels Jan 23, 2023
@alexrp alexrp added this to the v4.0 milestone Jan 23, 2023
@alexrp alexrp self-assigned this Jan 23, 2023
@alexrp alexrp modified the milestones: v4.0, v4.1 Aug 4, 2023
@alexrp alexrp modified the milestones: v4.1, v4.2 Jan 2, 2024
@alexrp
Copy link
Member Author

alexrp commented Jan 5, 2024

The current behavior actually matches what MSBuild and the .NET SDK does when you set multiple TFMs; only the inner builds trigger BeforeBuild/AfterBuild. I'm not sure why I thought otherwise.

That said, it still seems useful to provide a hook for this use case.

@alexrp alexrp closed this as completed in fb09251 Jan 5, 2024
@alexrp alexrp removed the state: approved Enhancements and tasks that have been approved. label Jan 5, 2024
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sdk Issues related to the MSBuild SDK.
Development

No branches or pull requests

1 participant