Fix negative cost in some IntersectVisitor implementations after apac…

…he#14138 (apache#14150) Introduced in apache#14138, we need to prevent negative scores when subtracting the added hits in LatLonPointDistanceQuery, SpatialQuery and PointRangeQuery.
vigyasharma · Jan 18, 2025 · dce24c8 · dce24c8
1 parent a4434ca
commit dce24c8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lucene/core/src/java/org/apache/lucene/document/LatLonPointDistanceQuery.java b/lucene/core/src/java/org/apache/lucene/document/LatLonPointDistanceQuery.java
@@ -280,7 +280,7 @@ public void visit(IntsRef ref) {
             for (int i = 0; i < ref.length; i++) {
               result.clear(ref.ints[ref.offset + i]);
             }
-            cost[0] = -ref.length;
+            cost[0] = Math.max(0, cost[0] - ref.length);
           }
 
           @Override

diff --git a/lucene/core/src/java/org/apache/lucene/document/SpatialQuery.java b/lucene/core/src/java/org/apache/lucene/document/SpatialQuery.java
@@ -677,7 +677,7 @@ public void visit(IntsRef ref) {
         for (int i = 0; i < ref.length; i++) {
           result.clear(ref.ints[ref.offset + i]);
         }
-        cost[0] -= ref.length;
+        cost[0] = Math.max(0, cost[0] - ref.length);
       }
 
       @Override

diff --git a/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java b/lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
@@ -233,7 +233,7 @@ public void visit(IntsRef ref) {
             for (int i = ref.offset; i < ref.offset + ref.length; i++) {
               result.clear(ref.ints[i]);
             }
-            cost[0] -= ref.length;
+            cost[0] = Math.max(0, cost[0] - ref.length);
           }
 
           @Override