Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal does not obey data-bs-theme #522

Closed
daveclarkit opened this issue Jan 22, 2024 · 2 comments · Fixed by #895
Closed

Modal does not obey data-bs-theme #522

daveclarkit opened this issue Jan 22, 2024 · 2 comments · Fixed by #895
Assignees
@gvreddy04
Labels
area-modal bug Something isn't working
Milestone
3.1.0

Comments

@daveclarkit
Copy link

when opening a Modal the header is drawn in light mode even if you have data-bs-theme="dark" set

To Reproduce
Steps to reproduce the behavior:

  1. Create a new project using Bootstrap Blazor
  2. Set data-bs-theme="dark"
  3. Create a Modal
  4. Open Modal
  5. See error

Expected behavior
Should be Dark!.

image

Versions (please complete the following information):

  • BlazorBootstrap: 1.10.5
  • Blazor WebAssembly
  • .NET Version: 8

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: edge
  • Version 122.0.2348.0 (Official build) stable app, dev channel (64-bit)
@MarvinKlein1508
Copy link

Can confirm this.

As a workaround you can set ModalType="ModalType.Dark"

MarvinKlein1508 referenced this issue in MarvinKlein1508/blazorbootstrap Mar 7, 2024
@MarvinKlein1508
Fix #522 by adding ModalType.Default
100ef13
@MarvinKlein1508 MarvinKlein1508 mentioned this issue Mar 7, 2024
Closed
@MarvinKlein1508
Copy link

@gvreddy04 I took another look on this and added a PR to fix this.

@gvreddy04 gvreddy04 added this to the 3.1.0 milestone Oct 1, 2024
gvreddy04 added a commit that referenced this issue Oct 1, 2024
@gvreddy04
#522 Modal does not obey data-bs-theme
0eae1de
@gvreddy04 gvreddy04 self-assigned this Oct 1, 2024
@gvreddy04 gvreddy04 added the bug Something isn't working label Oct 1, 2024
@gvreddy04 gvreddy04 linked a pull request Oct 6, 2024 that will close this issue
Dark mode support #895
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvreddy04 gvreddy04

Labels
area-modal bug Something isn't working
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Dark mode support vikramlearning/blazorbootstrap
3 participants
@gvreddy04 @MarvinKlein1508 @daveclarkit