-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix range inputs #554
Fix range inputs #554
Conversation
@MarvinKlein1508 I'm reviewing this PR. Could you help me reproduce this issue? If you wouldn't mind, could you share a screen recording of the issue? |
@gvreddy04 the decimal demo I've added is showcasing this issue. All your need is a browser with a locale which uses |
@MarvinKlein1508 Thank you for your quick reply on this. I'll test and complete this PR. |
@MarvinKlein1508 I changed the browser language to French to reproduce the issue, but I was not able to reproduce it. Please let me know if I'm missing anything. Additionally, please share the steps you followed to change the browser language. |
If I remember correctly then Google Chrome automatically fixes the behaviour. We had this issue for Try Firefox with German locale. |
It's also broken on Safari on with locale which uses |
@MarvinKlein1508 I was able to replicate this issue by using Opera with German. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Range inputs doesn't work when you want to use them with
float
,double
ordecimal
whenCultureInfo
uses a,
as seperator for floating points.Otherwise the component will behave buggy and renders invalid HTML.
This patch fixes this behaviour by always using
CultureInfo.InvariantCulture
to always work in all localizations.