Use IssueBuffer::maybeAdd() instead of throwing

vimeo · Feb 13, 2024 · f5fb949 · f5fb949
1 parent c3526b4
commit f5fb949
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php b/src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php
@@ -239,7 +239,12 @@ public static function parse(
                 if (count($param_parts) >= 2) {
                     $info->taint_sink_params[] = ['name' => $param_parts[1], 'taint' => $param_parts[0]];
                 } else {
-                    throw new IncorrectDocblockException('@psalm-taint-sink expects 2 arguments');
+                    IssueBuffer::maybeAdd(
+                        new InvalidDocblock(
+                            '@psalm-taint-sink expects 2 arguments',
+                            $code_location,
+                        ),
+                    );
                 }
             }
         }
@@ -282,7 +287,12 @@ public static function parse(
                 if ($param_parts[0]) {
                     $info->taint_source_types[] = $param_parts[0];
                 } else {
-                    throw new IncorrectDocblockException('@psalm-taint-source expects 1 argument');
+                    IssueBuffer::maybeAdd(
+                        new InvalidDocblock(
+                            '@psalm-taint-source expects 1 argument',
+                            $code_location,
+                        ),
+                    );
                 }
             }
         } elseif (isset($parsed_docblock->tags['return-taint'])) {

diff --git a/tests/Template/ConditionalReturnTypeTest.php b/tests/Template/ConditionalReturnTypeTest.php
@@ -759,7 +759,7 @@ private function getBody() : string {
                          * @template TSource as self::SOURCE_*
                          * @param TSource $source
                          * @return (TSource is "BODY" ? object|list : array)
-                         * @psalm-taint-source html
+                         * @psalm-taint-source input
                          */
                         public function getParams(
                             string $source = self::SOURCE_GET