Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PHPUnit configuration #4710

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Migrate PHPUnit configuration #4710

merged 1 commit into from
Nov 26, 2020

Conversation

gdejong
Copy link
Contributor

@gdejong gdejong commented Nov 26, 2020

While running some tests I noticed this warning:

PHPUnit 9.4.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.12 with Xdebug 2.9.8
Configuration: /opt/project/phpunit.xml.dist
Random Seed:   1606407050
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

As suggested, I used vendor/bin/phpunit --migrate-configuration to perform the migration, followed by some manual reformatting.

The migration refactored xsi:noNamespaceSchemaLocation to point to https://schema.phpunit.de/9.3/phpunit.xsd. I reverted that to ./vendor/phpunit/phpunit/phpunit.xsd but if you want I can change it to point to schema.phpunit.de

@muglug muglug merged commit a183aaf into vimeo:master Nov 26, 2020
@muglug
Copy link
Collaborator

muglug commented Nov 26, 2020

Thanks!

@gdejong gdejong deleted the migrate-phpunit-configuration branch November 26, 2020 20:24
danog pushed a commit to danog/psalm that referenced this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants