Reworking of the jsonrpc server #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
force-pushed
the
macros/patch-jsonrpcv2
branch
from
2aa2c58 to
5e9a96c
Compare
|
OK testing it on a server I get the following looks like the buffer is truncated |
Signed-off-by: Vincenzo Palazzo <[email protected]>
Removed the code that it is not longer used by the previous code refactoring. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/patch-jsonrpcv2
branch
from
88d2bed to
ed6ba58
Compare
Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
Harshit933
reviewed
May 24, 2024
| continue; | ||
| } | ||
|
|
||
| if event.is_invalid() { | ||
| log::info!(target: "jsonrpc", "event invalid, unregister event from the tracking one"); | ||
| log::warn!(target: "jsonrpc", "event invalid: {:?}", event); |
There was a problem hiding this comment.
This gives me the warning everytime I run lampo-cli --network regtest getinfo.
2024-05-24T16:13:35.386Z WARN jsonrpc event invalid: Event { key: Connect, source: Source { fd: 15, events: 519, revents: 32 } }. [lampo-jsonrpc/src/lib.rs:281]
Should we take care of this or should we ignore this everytime.
This is the basic flow of events whenever I am querying the node.
RPCEvent::AcceptRPCEvent::Connect && event.is_readable()RPCEvent::Connect and the event.is_invalid()-> This throws the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative version for #216