Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getinfo) : specify address inside getinfo #229

Merged
merged 1 commit into from
May 25, 2024

Conversation

Harshit933
Copy link
Collaborator

This commit adds the address inside getinfo command. Changelog:

  • Adds NetworkInfo response inside lampo_common::model
    This is done taking in mind the future work that we do on lampo.

Sample output for getinfo :

[doom@archlinux ~]$ lampo-cli --network regtest getinfo
{
  "node_id": "02cc3f4c11351843d755569204a69c48cb4233b788392a13d3cf67bb412b14c90f",
  "peers": 0,
  "channels": 0,
  "chain": "regtest",
  "alias": "doom",
  "blockheight": 105,
  "lampo_dir": "/home/doom/.lampo",
  "address": [
    {
      "address": "127.0.0.1",
      "port": 39736
    }
  ]
}

Copy link
Owner

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reactivity on this problem!

left a couple of review

lampod/src/ln/inventory_manager.rs Outdated Show resolved Hide resolved
lampo-common/src/model/network.rs Outdated Show resolved Hide resolved
Copy link
Owner

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes you will make trivial mistake that required an additional iteration.

If you read the other code you see a patter that help you avoid this mistakes

lampo-common/src/model.rs Outdated Show resolved Hide resolved
lampo-common/src/model.rs Outdated Show resolved Hide resolved
lampod/src/ln/inventory_manager.rs Outdated Show resolved Hide resolved
This commit adds the address inside `getinfo` command.
Changelog:
- Adds `NetworkInfo` response inside lampo_common::model
Copy link
Owner

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4fe3965

@vincenzopalazzo vincenzopalazzo merged commit a6dfe90 into vincenzopalazzo:main May 25, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants