-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(getinfo) : specify address inside getinfo #229
feat(getinfo) : specify address inside getinfo #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reactivity on this problem!
left a couple of review
cea5b07
to
0f3f028
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes you will make trivial mistake that required an additional iteration.
If you read the other code you see a patter that help you avoid this mistakes
This commit adds the address inside `getinfo` command. Changelog: - Adds `NetworkInfo` response inside lampo_common::model
0f3f028
to
4fe3965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4fe3965
This commit adds the address inside
getinfo
command. Changelog:NetworkInfo
response inside lampo_common::modelThis is done taking in mind the future work that we do on lampo.
Sample output for
getinfo
: