fix: avoid invalidating when drawing #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently in
onDraw()
, the view is sometimes invalidated. This means it will be infinitely redrawn. You can see the behavior by enabling the "Show screen updates" setting in the Android debug settings.Attached is two videos, the current 1.1.2 version that does infinite redraw, and the proposed fix that don't redraw unless needed.
redraw-issue.zip
It result in poor performance.
Another side effect is that our instrumented tests will wait for the render thread to finish, and that will never happen, so tests are ending in a timeout.
I also removed two unneeded calls to
initTimeline()
fromshowStartLine()
andshowEndLine()
since they are private and only called byinitLine()
that will callinitTimeline()
itself.Thanks for sharing your work on this library.