New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allowBackup, supportsRtl and label from AndroidManifest #92

Merged

vipulasri merged 1 commit into vipulasri:master from henriquenfaria:remove-irrelevant-manifest-properties

May 29, 2020

Contributor

henriquenfaria commented May 29, 2020

fixes #71

Those properties can cause conflicts when merging the app and the library manifests.

Manifest merger failed :  Attribute application@allowBackup value=(false) from AndroidManifest.xml:28:9-36
is also present at [com.github.vipulasri:timelineview:1.1.4] AndroidManifest.xml:12:9-35 value=(true).
Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:26:5-155:19 to override.

Manifest merger failed : Attribute application@supportsRtl value=(false) from AndroidManifest.xml:32:9-36
is also present at [com.github.vipulasri:timelineview:1.1.4] AndroidManifest.xml:14:9-35 value=(true).
Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:26:5-157:19 to override.


          Remove allowBackup, supportsRtl and label from AndroidManifest

ca69086

Contributor Author

henriquenfaria commented May 29, 2020

@vipulasri you can reproduce this issue by setting supportsRtl or allowBackup to false in the app's manifest.

vipulasri merged commit f5838d5 into vipulasri:master

henriquenfaria deleted the remove-irrelevant-manifest-properties branch

May 29, 2020 11:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet