chore: projection test app #9200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Oct 4, 2024
test/apps/projection/app.tsx
Outdated
|
|
||
| const opts = VIEWS[viewMode]; | ||
|
|
||
| const pointData = React.useMemo(() => makePointGrid(opts), [viewMode]); |
There was a problem hiding this comment.
Would be nice to include a finer grid around zoom 12 to see how much we deviate from the adaptive projection in maplibre
chrisgervang
approved these changes
Oct 4, 2024
| initializeState({device}: LayerContext) { | ||
| const canvas = device.canvasContext?.canvas as HTMLCanvasElement; | ||
| if (canvas) { | ||
| const container = appendSVGElement(canvas.parentElement!, 'svg'); |
There was a problem hiding this comment.
Interesting use of a deck layer.
Is it correct to say this renders a 2D grid with SVG over the canvas? I'm assuming this only works since pitch is 0?
test/apps/projection/app.tsx
Outdated
|
|
||
| const layers = [ | ||
| // Reference grid when base map is not available (non-geo) | ||
| !opts.baseMap && |
There was a problem hiding this comment.
Could it be useful to visually compare the deck lines with the basemap lines by overlapping them and rendering them in different colors?
I'm curious about how to perform a projection check
|
Huh, merging master in revealed this was added in #9201. Close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9199
Change List