-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added wireguard link type #464
Conversation
xaionaro
commented
Jun 29, 2019
•
edited
Loading
edited
AFAICT wireguard is not in Linux kernel yet, please correct me if I am wrong. |
Could we re-open this? Wireguard has been pulled into Linux 5.6. |
IMO we should do that. @vishvananda, @aboch ping. |
@vishvananda any updates on this issue ? :) |
@aboch ping |
go.mod
Outdated
@@ -1,8 +1,9 @@ | |||
module github.com/vishvananda/netlink | |||
module github.com/xaionaro-go/netlink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aboch : Yes, sorry. My PR was closed (without merging) so I was have to fork the project. I'll cleanup that things in few minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aboch : I've just removed the garbage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll also add an unit-test, few minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an unit-test:
$ sudo go test ./... -count=1 -run=TestLinkAddDelWireguard
ok github.com/vishvananda/netlink 0.045s
ok github.com/vishvananda/netlink/nl 0.002s [no tests to run]
Added type "Wireguard" which implements link type "wireguard". See also https://www.wireguard.com/ Signed-off-by: Dmitrii Okunev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM