Properly handle uint64 for HTB class rate/ceil #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aboch @vishvananda could one of you have a look at this PR? |
aboch
reviewed
Mar 10, 2021
| @@ -268,7 +268,8 @@ func TestHtbClassAddHtbClassChangeDel(t *testing.T) { | |||
| } | |||
|
|
|||
| htbclassattrs := HtbClassAttrs{ | |||
| Rate: 1234000, | |||
| Rate: uint64(1<<32) + 10, | |||
| Ceil: uint64(1<<32) + 20, | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, providing a rate or a ceil with a value higher than the
uint32max results in the value overflowing and a HTB class with wrong ceil/rate is created without any errors. The kernel already supportsuint64values so adding support for it to the library was relatively easy.I also adjusted the test to use large values to verify that it works properly. With the old implementation, the same test would fail