devlink port add, delete, function get/set attributes #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please review? Want to proceed to use in a new cni plugin. |
|
Hi @vishvananda, Gentle remind. If we can proceed with this enhancement. |
|
Did you get a chance to review it? Can we please proceed? |
|
@vishvananda @aboch |
|
pls push something so that the CI runs |
Extend devlink port for optional port function attributes. Signed-off-by: Parav Pandit <[email protected]>
Add APIs to add and delete a devlink port of specified flavour for a given devlink device. Extended test to accept devlink device and sf number parameters from the test command line. Signed-off-by: Parav Pandit <[email protected]>
Add ability to set port function attributes such as state and hardware address. Signed-off-by: Parav Pandit <[email protected]>
|
@aboch, thanks for the input. I pushed again after rebase. All checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset consist of 3 main functionalities.
Patchset contains relevant test cases as well with a ability to specify device handle at command line.