Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdma: support rdma link add/del functionality #641

Merged
merged 1 commit into from
Sep 18, 2021
Merged

rdma: support rdma link add/del functionality #641

merged 1 commit into from
Sep 18, 2021

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Apr 19, 2021

Signed-off-by: Wei Fu [email protected]

paravmellanox
paravmellanox reviewed May 8, 2021
View reviewed changes
Copy link
Contributor

@paravmellanox paravmellanox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuweid

Pease address these small cosmetic issues. Rest of the code looks good.

rdma_link_linux.go Outdated Show resolved Hide resolved
rdma_link_linux.go Outdated Show resolved Hide resolved
rdma_link_test.go Show resolved Hide resolved
rdma_link_test.go Outdated Show resolved Hide resolved
@aboch
Copy link
Collaborator

aboch commented Sep 18, 2021

@fuweid can you pls take address/respond to @paravmellanox 's comments?

Also, pls rebase and force push so that CI (now fixed) will be triggered

@fuweid fuweid force-pushed the support-rdma-add-link branch 2 times, most recently from 44fb06f to db0d2a2 Compare September 18, 2021 15:15
@fuweid
Copy link
Contributor Author

fuweid commented Sep 18, 2021

@aboch @paravmellanox updated and PTAL. Thanks!

@fuweid
Copy link
Contributor Author

fuweid commented Sep 18, 2021 

➜  netlink git:(support-rdma-add-link) go test -count 1 -v -run TestRdmaLinkAddAndDel ./
=== RUN   TestRdmaLinkAddAndDel
--- PASS: TestRdmaLinkAddAndDel (0.01s)
PASS
ok      github.com/vishvananda/netlink  0.013s
➜  netlink git:(support-rdma-add-link) uname -a
Linux ubuntu-focal 5.11.0-34-generic #36-Ubuntu SMP Thu Aug 26 19:22:09 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

The test result is on my local. Hope it can help.

@aboch
Copy link
Collaborator

aboch commented Sep 18, 2021

LGTM

@aboch aboch merged commit c33185c into vishvananda:master Sep 18, 2021
@fuweid fuweid deleted the support-rdma-add-link branch September 19, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paravmellanox paravmellanox paravmellanox left review comments

@aboch aboch aboch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fuweid @aboch @paravmellanox