rdma: add netdev field for rdma link info #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishvananda @aboch wondering if you can take a look at this pr? Thanks! |
e0ne
suggested changes
Jan 3, 2023
There was a problem hiding this comment.
The change itself looks good to me. @avvarikrish please add unit-tests for the new feature
aboch
reviewed
Jul 3, 2024
| @@ -54,6 +56,11 @@ func executeOneGetRdmaLink(data []byte) (*RdmaLink, error) { | |||
| r := bytes.NewReader(value) | |||
| binary.Read(r, nl.NativeEndian(), &Index) | |||
| link.Attrs.Index = Index | |||
| case nl.RDMA_NLDEV_ATTR_PORT_INDEX: | |||
| var Index uint32 | |||
There was a problem hiding this comment.
Why is Index with a capital I?
aboch
reviewed
Jul 3, 2024
| return nil | ||
| } | ||
|
|
||
| return fmt.Errorf("link %v not found or unexpected number of msgs", link.Attrs.Name) |
There was a problem hiding this comment.
Please also print the number of msgs
[...] of msgs (%d)", link.Attrs.Name, len(msgs))
aboch
reviewed
Jul 3, 2024
| } | ||
| if (len % 4) != 0 { | ||
| // Skip pad bytes | ||
| reader.Seek(int64(4-(len%4)), seekCurrent) |
There was a problem hiding this comment.
make sure to gofmt your new code
aboch
reviewed
Jul 3, 2024
| if len(msgs) == 1 { | ||
| netdev, err := executeOneGetRdmaNetdev(msgs[0]) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Should this error message provide a little ore context? for example the name of the requested device?
|
@avvarikrish ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow users to get the underlying network interface associated with each rdma link. It is essentially the
netdevattribute for an rdma link.