Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy html path should be encoded #15223

Merged
merged 3 commits into from
Dec 3, 2023

Conversation

patak-dev
Copy link
Member

Description

After #13581, the htmlProxy URLs were unencoded. This PR reverts this change, still fixing the linked bugs (there was a test added in that PR).

I tried two approaches, the second commit has the keys in the proxy HTML cache decoded. I think this is the simpler of the two.

There was also an issue when pre-transforming requests in index HTML middleware, the URLs sent to warmupRequest should be decoded. Once I did the fix, the ssr-deps playground started to fail for this reason. I added the decoding logic there too.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 2, 2023
@patak-dev
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 4ea1c57: Open

suite result latest scheduled
analogjs success success
astro success success
histoire success failure
ladle success success
laravel failure failure
marko success success
nuxt failure failure
nx success success
previewjs success success
qwik success success
rakkas success success
sveltekit success failure
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants