fix: srcSet with optional descriptor

[murad-khafizov]

There is a bug processing simple <source srcSet='someURL'>, that adds a trailing space at the end of the URL, i.e. it becomes: <source srcSet='someURL '>
That creates a mismatch between SSR-generated HTML and HTML on the client side.

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines, especially the Pull Request Guidelines.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Update the corresponding documentation if needed.
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[hi-ogawa]

Thanks for the PR. This might be a bug on its own (and thus worth fixing), but I think it would be still nice if you can prepare a reproduction revealing this bug as a Vite user.

For example, do you apply transformIndexHtml to entire SSR render html? It looks like a few issues with this usage have come up recently, but it's not considered to be an officially supported usage for now #15345 (comment) #15662 (comment)

[patak-dev]

Thanks for the failing test. This exposed a real bug with optional descriptors. Fixed in 87a647f

[murad-khafizov]

For example, do you apply transformIndexHtml to entire SSR render html? It looks like a few issues with this usage have come up recently, but it's not considered to be an officially supported usage for now #15345 (comment) #15662 (comment)

Yes, I apply transformIndexHtml to the entire HTML indeed. Tbh I didn't know it's not recommended, but we used it this way from the very beginning. Anyway thanks, I'll check it.

[murad-khafizov]

Thanks for the failing test. This exposed a real bug with optional descriptors. Fixed in 87a647f

Thanks a lot for the quick reaction! Looking forward to the new release :)