Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): convert diagrams #15927

Merged
merged 3 commits into from
Feb 16, 2024
Merged

docs(contributing): convert diagrams #15927

merged 3 commits into from
Feb 16, 2024

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Feb 15, 2024

Description

replace the images with mermaid diagrams so they can be edited

Additional context

fixes #15923


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Nice! Thanks a lot for taking this one so quickly 🙌🏼

Would you delete the images and the .excalidraw files as part of this PR?

(could have used those for the text instead of copy pasting haha)
@Haroenv
Copy link
Contributor Author

Haroenv commented Feb 16, 2024

removed the other source files @patak-dev :)

@patak-dev patak-dev added the documentation Improvements or additions to documentation label Feb 16, 2024
@patak-dev
Copy link
Member

Thanks a lot @Haroenv! We also have the same graphs in Vitest contributing guide https://github.com/vitest-dev/vitest/blob/main/CONTRIBUTING.md#issue-triaging-workflow. Given that you did the work already, would you like to send a PR there too? You get to be a contributor to Vitest too :)

@patak-dev patak-dev merged commit 71dc6a6 into vitejs:main Feb 16, 2024
10 checks passed
@Haroenv Haroenv deleted the patch-1 branch February 16, 2024 14:55
Haroenv added a commit to Haroenv/vitest that referenced this pull request Feb 16, 2024
@Haroenv
Copy link
Contributor Author

Haroenv commented Feb 16, 2024

added a PR there too @patak-dev :) vitest-dev/vitest#5222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Issues and PR workflows to mermaid
2 participants