fix: don't overwrite default options unless given new value #5111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you set a single option in
commonjsOptions
ordynamicImportVarsOptions
then the defaults for those options (e.g.commonjsOptions: { include: [/node_modules/], extensions: ['.js', '.cjs']}
will get overridden on line 259. I'm guessing that's not intended or else lines 240 & 245 could simply be removedAdditional context
I was investigating an issue that turned out to be an issue in
@rollup/plugin-commonjs
and was reading the code here when I stumbled across thisWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).