Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve issue templates #8699

Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jun 21, 2022

Description

Update issue templates to encourage people to write more information.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Jun 21, 2022
@patak-dev
Copy link
Member

Looks good! I was thinking if we should ask the user to give use the error logs inside of a

<details>
  <summary>Click to expand!</summary>
  
  ```javascript
    function logSometing(something) {
      console.log(`Logging: ${something}`);
    }
  ```
</details>

So it is collapsible. Having to scroll isn't good, and we usually reproduce the error ourselves anyways (more when we have a link to stackblitz)
Is this something that is possible with issues forms?

@sapphi-red
Copy link
Member Author

It seems this is the best choice.
image

If value was set, the <details> will appear even if the users didn't paste logs.

@patak-dev
Copy link
Member

You rock!

@patak-dev patak-dev merged commit 0cbb33b into vitejs:main Jun 21, 2022
@sapphi-red sapphi-red deleted the chore/improve-issue-template-and-bot branch June 21, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants