Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-worker): share mocker with main executor #6623

Merged
merged 6 commits into from
Oct 3, 2024
Merged

fix(web-worker): share mocker with main executor #6623

merged 6 commits into from
Oct 3, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 3, 2024 •
edited
Loading

Description

It looks like previously mock state is shared between executors via WorkerGlobalState.mockMap, but it's removed and moved to VitestMocker.registry in #6289

Not sure if this is the most robust way, but we can grab main mocker from __vitest_mocker__ global and it seems this gives a similar effect as before.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8baf1cb
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66fe402c48ddc400084332ff
😎 Deploy Preview https://deploy-preview-6623--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title fix(web-worker): reuse main executor mocker fix(web-worker): share mocker with main executor Oct 3, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review October 3, 2024 07:40
@sheremet-va sheremet-va merged commit fe7b8ae into vitest-dev:main Oct 3, 2024
17 checks passed
@hi-ogawa hi-ogawa deleted the fix-worker-mock-share branch October 3, 2024 09:30
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Oct 14, 2024
@renovate
chore(deps): update dependency vitest to v2.1.3
ff2649f 
##### [v2.1.3](https://github.com/vitest-dev/vitest/releases/tag/v2.1.3)

#####    🐞 Bug Fixes

-   Fix error diff of `toBeNaN, toBeUndefined, toBeNull, toBeTruthy, toBeFalsy`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6697 [<samp>(e0027)</samp>](vitest-dev/vitest@e002758c)
-   **browser**:
    -   Provide aria role intellisense  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6629 [<samp>(f36ea)</samp>](vitest-dev/vitest@f36eac77)
    -   Not.toBeInTheDocument works with locators API  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6634 [<samp>(8bef5)</samp>](vitest-dev/vitest@8bef5d2b)
    -   Use `/mockServiceWorker.js` instead of `/__vitest_msw__`  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6687 [<samp>(4b2ce)</samp>](vitest-dev/vitest@4b2ce07f)
    -   Don't override the esbuild option in the browser mode  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6692 [<samp>(d131f)</samp>](vitest-dev/vitest@d131fd64)
-   **expect**:
    -   Preserve prototype in `toMatchObject` diff  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6620 [<samp>(d289e)</samp>](vitest-dev/vitest@d289e7eb)
-   **mocker**:
    -   Specify correct spy dependency  -  by [@sheremet-va](https://github.com/sheremet-va) [<samp>(7e958)</samp>](vitest-dev/vitest@7e9584aa)
-   **runner**:
    -   Ensure sequential suite overrides sequence.concurrent  -  by [@dsyddall](https://github.com/dsyddall) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6653 [<samp>(5e6de)</samp>](vitest-dev/vitest@5e6de274)
-   **vitest**:
    -   Deprecate UserConfig in favor of ViteUserConfig  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6626 [<samp>(496bd)</samp>](vitest-dev/vitest@496bd251)
    -   Don't hang with maxConcurrency 0  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6627 [<samp>(946d8)</samp>](vitest-dev/vitest@946d8bb1)
    -   Deprecate old task types and node-reliant types  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6632 [<samp>(00045)</samp>](vitest-dev/vitest@000459a9)
    -   Fix `<empty line>` logs when interleaving `console.log/error`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6644 [<samp>(9ece3)</samp>](vitest-dev/vitest@9ece3952)
    -   Show rollup error details as test error  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6686 [<samp>(47dde)</samp>](vitest-dev/vitest@47dde76f)
    -   Always inline setup files  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6689 [<samp>(19d64)</samp>](vitest-dev/vitest@19d64e20)
    -   Use `fast-glob` instead of `tinyglobby` in Vitest  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6688 [<samp>(70baa)</samp>](vitest-dev/vitest@70baaaa9)
-   **web-worker**:
    -   Share mocker with main executor  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6623 [<samp>(fe7b8)</samp>](vitest-dev/vitest@fe7b8aee)

#####    🏎 Performance

-   Reuse full name in reported tasks, update generator types  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6666 [<samp>(7a0de)</samp>](vitest-dev/vitest@7a0de0a7)

#####     [View changes on GitHub](vitest-dev/vitest@v2.1.2...v2.1.3)
@renovate renovate bot mentioned this pull request Oct 25, 2024
Open
1 task
This was referenced Nov 5, 2024
Open
Open
@renovate renovate bot mentioned this pull request Nov 5, 2024
Open
1 task
This was referenced Nov 5, 2024
Open
Open
@nerds-github nerds-github mentioned this pull request Nov 6, 2024
Open
@Laurry-gee Laurry-gee mentioned this pull request Nov 6, 2024
Open
This was referenced Nov 6, 2024
Open
Open
@Laurry-gee Laurry-gee mentioned this pull request Nov 7, 2024
Open
This was referenced Nov 7, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Nov 10, 2024
Open
@renovate renovate bot mentioned this pull request Nov 13, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpyOn a module function imported by a web worker stops working in 2.1.0-beta.7/2.1.0/2.1.1
2 participants
@hi-ogawa @sheremet-va