feat(cli): show test "path" when filtering #6649
Open
+55
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
changed the title
6 tasks
userquin
commented
Oct 8, 2024
packages/vitest/src/node/stdin.ts
Outdated
| } | ||
| else { | ||
| for (const task of t.tasks) { | ||
| yield * traverseFilteredTestNames([...stack, task.name], filter, task) |
There was a problem hiding this comment.
add parentName: string instead recreating the array
There was a problem hiding this comment.
latest commit also fixes duplicate test names - check the screenshot, t1 appears twice
userquin
commented
Oct 8, 2024
| @@ -9,13 +9,18 @@ const MAX_RESULT_COUNT = 10 | |||
| const SELECTION_MAX_INDEX = 7 | |||
| const ESC = '\u001B[' | |||
|
|
|||
| type FilterFunc = (keyword: string) => Promise<string[]> | string[] | |||
| export interface FilterType { | |||
There was a problem hiding this comment.
Rename this to FilterObject or FilterItem and replace name with key.
This way when we add the x command to run a test/suite we we just use key with the corresponding id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to filtering from command line here: #6641 (compare screenshots there and here)
This PR allows declare the watcher filter using a new interface to display the list with the test path removing duplicates files when using workspaces. Right now, filtering tests will run any test in any files and workspace matching the name of the selected item (test name).
NOTE: we should add a new
runByIdto allow run only a test (the UI will use it)filtering from command line with this PR
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.