Faster runtime of predict_win and predict_draw #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philihp
commented
Mar 1, 2022
vivekjoshy
requested changes
Mar 1, 2022
There was a problem hiding this comment.
Please format the code with black . so that the checks can pass. Can you also add two spaces between the test functions for predicting wins as per PEP 8 E302.
|
Sure thing! (sorry Python is a new language to me, I'll see what I can do) |
* main: Bump furo from 2022.2.23 to 2022.3.4 Fix wrong variable in benchmarks
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 503 488 -15
Branches 110 106 -4
=========================================
- Hits 503 488 -15
Continue to review full report at Codecov.
|
vivekjoshy
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
itertools.permutationsto give permutation pairs, rather than all full permutationsI noticed that for teams of ABCD, your code as written was finding all permutations (ABCD, ABDC, ACBD, ACDB, ...) and then only using the first two from the permutation, which for n>=4 teams, this causes the same pairings to be calculated multiple times.
This should reduce runtime from O(n^n) to O(n^2).
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under openskill.py's MIT license.
I certify the above statement is true and correct:
Philihp Busby