Docker-Compose Deployment, #588 #388
Open
+235
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarnutsch
commented
Nov 6, 2024
auto-assign
bot
requested review from
fraxachun,
johnnyomair,
nsams and
thomasdax98
|
I've decided that "maybe systemctl file" is out of scope for this PR. So from my point of view it is ready for review. |
johnnyomair
reviewed
Nov 13, 2024
dkarnutsch
commented
Nov 14, 2024
fraxachun
previously approved these changes
Dec 2, 2024
thomasdax98
previously approved these changes
Dec 2, 2024
dkarnutsch
dismissed stale reviews from thomasdax98 and fraxachun
via
34c429b
|
I've updated to Node 22 und fixed the builds for admin and site (as they rely on git) with 34c429b |
fraxachun
previously approved these changes
Dec 3, 2024
kaufmo
reviewed
Dec 4, 2024
| @@ -0,0 +1,15 @@ | |||
| FROM registry.access.redhat.com/ubi9/nodejs-22:latest | |||
There was a problem hiding this comment.
whats the reason for not using minimal image everywhere?
There was a problem hiding this comment.
The build process requires git. Instead of installing it manually, I decided to use the "regular" image.
admin/Dockerfile
Outdated
| npm run build && \ | ||
| rm -rf ./node_modules | ||
|
|
||
| CMD "npm" "run" "serve" |
There was a problem hiding this comment.
running node directly here would use less memory
| @@ -0,0 +1,16 @@ | |||
| FROM registry.access.redhat.com/ubi9/nodejs-22:latest | |||
There was a problem hiding this comment.
same as above api uses minimal why not here to?
johnnyomair
previously approved these changes
Dec 4, 2024
dkarnutsch
dismissed stale reviews from johnnyomair and fraxachun
via
56634ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#588
Open TODOs/questions