New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove command for removing site #577

Open

fraxachun wants to merge 1 commit into main from remove-remove-site

Contributor

fraxachun commented Nov 29, 2024

Reasons to remove this feature:

It does not make changes in Admin/API which are normally made to transform to a Data-driven application
It cannot handly the removal of site-configs properly
It is prone to not being updated on changes in comet/starter
There is no automatic process of verifying that the web and/or the deployment works after executing the command


          Remove command for removing site

auto-assign bot requested review from dkarnutsch, johnnyomair, manuelblum, nsams and thomasdax98

November 29, 2024 08:12

auto-assign bot assigned fraxachun

fraxachun mentioned this pull request

Make project starting when site is removed via create-app #565

Open

johnnyomair approved these changes

View reviewed changes

Member

thomasdax98 commented Dec 3, 2024

I'm against this. Though not perfect, this eases the process of removing the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

johnnyomair johnnyomair approved these changes

dkarnutsch Awaiting requested review from dkarnutsch

manuelblum Awaiting requested review from manuelblum

nsams Awaiting requested review from nsams

thomasdax98 Awaiting requested review from thomasdax98

Labels

None yet