Add lint workflow @comet/create-app
#583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyomair
force-pushed
the
lint-create-app
branch
5 times, most recently
from
d9db1bd to
13259ad
Compare
johnnyomair
changed the title
@comet/create-app@comet/create-app
johnnyomair
force-pushed
the
lint-create-app
branch
from
13259ad to
1fe4e2b
Compare
johnnyomair
commented
Dec 4, 2024
| @@ -17,6 +17,7 @@ The following arguments can be passed to customize the project setup: | |||
|
|
|||
| - `project-name` (required): Specifies the name of the project. It will be used as the directory name for the project. | |||
| - `-ni` or `--no-install`: Disables the automatic installation of dependencies. | |||
| - `-nc` or `--no-commit`: Disables the initial commit. | |||
There was a problem hiding this comment.
I figured that committing in the pipeline doesn't make sense. However, now the repository initialization isn't tested. What do you think? Should I try if committing in the pipeline even works?
johnnyomair
commented
Dec 4, 2024
Comment on lines
+97
to
+98
| - name: Remove the site | ||
| run: cd create-app/test && node ../bin/index.js remove-site |
There was a problem hiding this comment.
After this, I'd like to check if the script worked. I can think of two ways:
- Start the application and see if it still runs
- Check for occurrences of certain terms, e.g., site and site config.
I believe 2. would be enough, what do you think?
johnnyomair
commented
Dec 4, 2024
| @@ -10,8 +10,10 @@ export function runEslintFix(verbose: boolean) { | |||
| for (const microservice of microservices) { | |||
| if (!fs.existsSync(microservice)) { | |||
| continue; | |||
| } else if (!hasDependenciesInstalled(microservice) && verbose) { | |||
There was a problem hiding this comment.
The if didn't work as expected, because verbose was false or undefined. Split into two ifs to get it to work again.
auto-assign
bot
requested review from
dkarnutsch,
fraxachun,
manuelblum,
nsams and
thomasdax98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a lint workflow for
@comet/create-app. It lints, builds, and runs the script.