Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Demo to latest Comet Starter #2899

Merged
merged 30 commits into from
Dec 18, 2024
Merged

Update Demo to latest Comet Starter #2899

merged 30 commits into from
Dec 18, 2024

Conversation

piotrgulbis
Copy link
Contributor

@piotrgulbis piotrgulbis commented Dec 9, 2024 •
edited by johnnyomair
Loading

Update Demo to latest Comet Starter, keeping everything that was in Demo if possible.

@piotrgulbis piotrgulbis force-pushed the chore/update-demo-codebase branch from 148e0de to 136bb22 Compare December 9, 2024 11:11
@johnnyomair johnnyomair self-requested a review December 9, 2024 13:27
johnnyomair
johnnyomair reviewed Dec 10, 2024
View reviewed changes
demo/admin/src/common/apollo/createApolloClient.ts Outdated Show resolved Hide resolved
demo/admin/src/common/blocks/LinkListBlock.tsx Outdated Show resolved Hide resolved
demo/admin/src/common/blocks/TextLinkBlock.tsx Show resolved Hide resolved
demo/admin/src/pages/blocks/PageContentBlock.tsx Outdated Show resolved Hide resolved
demo/admin/src/pages/blocks/SeoBlock.tsx Outdated Show resolved Hide resolved
demo/api/src/db/migrations/Migration20220127092535.ts Outdated Show resolved Hide resolved
demo/api/src/db/migrations/Migration20220127092750.ts Outdated Show resolved Hide resolved
demo/api/src/footer/generated/footer.resolver.ts Outdated Show resolved Hide resolved
demo/site/src/documents/pages/blocks/FooterContentBlock.tsx Outdated Show resolved Hide resolved
demo/site/src/util/graphQLClient.ts Outdated Show resolved Hide resolved
@johnnyomair
Copy link
Collaborator

Some things that could be made as well

  1. Update the folder structure to match the Starter
  2. Remove outdated blocks from Demo, e.g., HeadlineBlock

@piotrgulbis
Copy link
Contributor Author

Some things that could be made as well

  1. Update the folder structure to match the Starter
  2. Remove outdated blocks from Demo, e.g., HeadlineBlock

I was not sure here what to remove and what to keep... For example I removed the LinkList as indicated by your comment but we should keep it, so there is no way I can know which to keep and which to throw away.

@piotrgulbis piotrgulbis marked this pull request as ready for review December 11, 2024 15:00
@auto-assign auto-assign bot requested a review from johnnyomair December 11, 2024 15:00
johnnyomair
johnnyomair reviewed Dec 12, 2024
View reviewed changes
demo/admin/src/App.tsx Show resolved Hide resolved
demo/admin/src/common/MasterMenu.tsx Show resolved Hide resolved
demo/admin/src/common/blocks/LinkListBlockWithAdditionalFields.tsx Outdated Show resolved Hide resolved
demo/admin/src/dashboard/DashboardPage.tsx Outdated Show resolved Hide resolved
demo/admin/src/documents/pages/mainMenu/MainMenu.tsx Outdated Show resolved Hide resolved
demo/site/src/blocks/CookieSafeYouTubeVideoBlock.tsx Outdated Show resolved Hide resolved
demo/site/src/blocks/LayoutBlock.tsx Outdated Show resolved Hide resolved
demo/site/src/common/helpers/GridRoot.tsx Outdated Show resolved Hide resolved
demo/site/src/documentTypes/Page.tsx Outdated Show resolved Hide resolved
docs/docs/blocks/block-factories.mdx Outdated Show resolved Hide resolved
@johnnyomair johnnyomair mentioned this pull request Dec 12, 2024
Merged
@piotrgulbis piotrgulbis force-pushed the chore/update-demo-codebase branch from a31ca11 to 15a1acb Compare December 16, 2024 12:31
@nsams nsams changed the title chore: update demo to latest comet starter Update demo to latest comet starter Dec 17, 2024
johnnyomair
johnnyomair reviewed Dec 17, 2024
View reviewed changes
demo/admin/src/App.tsx Outdated Show resolved Hide resolved
demo/admin/src/common/MasterMenu.tsx Show resolved Hide resolved
demo/admin/src/common/MasterMenu.tsx Outdated Show resolved Hide resolved
demo/admin/src/common/MasterMenu.tsx Outdated Show resolved Hide resolved
demo/admin/src/config.tsx Outdated Show resolved Hide resolved
demo/admin/src/dashboard/DashboardPage.tsx Outdated Show resolved Hide resolved
demo/admin/src/dashboard/DashboardPage.tsx Outdated Show resolved Hide resolved
demo/api/src/footer/entities/footer.entity.ts Outdated Show resolved Hide resolved
demo/api/src/footer/footer.module.ts Show resolved Hide resolved
demo/site/src/common/blocks/TextLinkBlock.tsx Outdated Show resolved Hide resolved
@piotrgulbis piotrgulbis force-pushed the chore/update-demo-codebase branch from 0670291 to a80663b Compare December 17, 2024 09:40
@johnnyomair johnnyomair changed the title Update demo to latest comet starter Update Demo to latest Comet Starter Dec 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@johnnyomair johnnyomair merged commit 4b48e6c into main Dec 18, 2024
13 of 14 checks passed
@johnnyomair johnnyomair deleted the chore/update-demo-codebase branch December 18, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair johnnyomair approved these changes

Assignees

@piotrgulbis piotrgulbis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotrgulbis @johnnyomair