-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update demo to latest comet starter #2899
base: main
Are you sure you want to change the base?
Conversation
148e0de
to
136bb22
Compare
Some things that could be made as well
|
I was not sure here what to remove and what to keep... For example I removed the LinkList as indicated by your comment but we should keep it, so there is no way I can know which to keep and which to throw away. |
import { UserGroupContextMenuItem } from "@src/userGroups/UserGroupContextMenuItem"; | ||
import { FormattedMessage } from "react-intl"; | ||
|
||
export const LinkListBlockWithAdditionalFields = createListBlock({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add a new link list block for this, keep it in the original block instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes a lot of other problems because if kept in the original block, the LinkList is used in the Footer and there is then a type mismatch because of the addition of userGroup field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @ts-expect-error
and TODOs instead. Otherwise we'll never fix this. You could even create a bug task.
@@ -1,13 +1,10 @@ | |||
import "@fontsource-variable/roboto-flex/full.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay to remove this font?
Quality Gate failedFailed conditions |
Update Demo to latest Comet-Starter, keeping everything that was in Demo if possible.