Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update demo to latest comet starter #2899

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

piotrgulbis
Copy link
Contributor

@piotrgulbis piotrgulbis commented Dec 9, 2024

Update Demo to latest Comet-Starter, keeping everything that was in Demo if possible.

@piotrgulbis piotrgulbis force-pushed the chore/update-demo-codebase branch from 148e0de to 136bb22 Compare December 9, 2024 11:11
demo/admin/src/common/apollo/createApolloClient.ts Outdated Show resolved Hide resolved
demo/admin/src/common/blocks/LinkListBlock.tsx Outdated Show resolved Hide resolved
demo/admin/src/pages/blocks/PageContentBlock.tsx Outdated Show resolved Hide resolved
demo/admin/src/pages/blocks/SeoBlock.tsx Outdated Show resolved Hide resolved
demo/api/src/db/migrations/Migration20220127092535.ts Outdated Show resolved Hide resolved
demo/api/src/db/migrations/Migration20220127092750.ts Outdated Show resolved Hide resolved
demo/api/src/footer/generated/footer.resolver.ts Outdated Show resolved Hide resolved
demo/site/src/util/graphQLClient.ts Outdated Show resolved Hide resolved
@johnnyomair
Copy link
Collaborator

Some things that could be made as well

  1. Update the folder structure to match the Starter
  2. Remove outdated blocks from Demo, e.g., HeadlineBlock

@piotrgulbis
Copy link
Contributor Author

Some things that could be made as well

  1. Update the folder structure to match the Starter
  2. Remove outdated blocks from Demo, e.g., HeadlineBlock

I was not sure here what to remove and what to keep... For example I removed the LinkList as indicated by your comment but we should keep it, so there is no way I can know which to keep and which to throw away.

@piotrgulbis piotrgulbis marked this pull request as ready for review December 11, 2024 15:00
@auto-assign auto-assign bot requested a review from johnnyomair December 11, 2024 15:00
demo/admin/src/App.tsx Outdated Show resolved Hide resolved
demo/admin/src/common/MasterMenu.tsx Outdated Show resolved Hide resolved
import { UserGroupContextMenuItem } from "@src/userGroups/UserGroupContextMenuItem";
import { FormattedMessage } from "react-intl";

export const LinkListBlockWithAdditionalFields = createListBlock({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add a new link list block for this, keep it in the original block instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes a lot of other problems because if kept in the original block, the LinkList is used in the Footer and there is then a type mismatch because of the addition of userGroup field.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @ts-expect-error and TODOs instead. Otherwise we'll never fix this. You could even create a bug task.

demo/admin/src/dashboard/DashboardPage.tsx Show resolved Hide resolved
demo/admin/src/documents/pages/mainMenu/MainMenu.tsx Outdated Show resolved Hide resolved
demo/site/src/blocks/CookieSafeYouTubeVideoBlock.tsx Outdated Show resolved Hide resolved
demo/site/src/blocks/LayoutBlock.tsx Outdated Show resolved Hide resolved
demo/site/src/common/helpers/GridRoot.tsx Outdated Show resolved Hide resolved
demo/site/src/documentTypes/Page.tsx Outdated Show resolved Hide resolved
docs/docs/blocks/block-factories.mdx Outdated Show resolved Hide resolved
@@ -1,13 +1,10 @@
import "@fontsource-variable/roboto-flex/full.css";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay to remove this font?

Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants