Best practice stories: Use EditDialog instead of MUIs Dialog
#2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er from showing upon saving
johnnyomair
reviewed
Dec 9, 2024
Comment on lines
+454
to
+456
| <EditDialog title={mode === "add" ? "Add new item" : `${rows.find((row) => row.id === selectedId)?.title}`}> | ||
| <Form id={mode === "add" ? undefined : selectedId} /> | ||
| </EditDialog> |
There was a problem hiding this comment.
@thomasdax98 is this how the EditDialog should be used with Selection? Seems odd to me...
| @@ -975,7 +932,7 @@ export const GridWithSelectionInDialog = { | |||
| <ToolbarAutomaticTitleItem /> | |||
| <ToolbarFillSpace /> | |||
| <ToolbarActions> | |||
| <Button color="primary" variant="contained" startIcon={<SelectIcon />} onClick={() => setShowDialog(true)}> | |||
| <Button color="primary" variant="contained" startIcon={<SelectIcon />} onClick={() => editDialogApi.openAddDialog()}> | |||
There was a problem hiding this comment.
This should probably be openEditDialog, since you're editing the current selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All MUI dialogs in the best practice stories are replaced with
EditDialog. This adds the dirty handler dialog to prevent losing unsaved changes.Screenshots/screencasts
Saving behaviour:
Screen.Recording.2024-12-09.at.13.34.10.mp4
Error behaviour:
Screen.Recording.2024-12-09.at.13.35.39.mp4
Changeset