Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove react imports #2906

Closed
wants to merge 3 commits into from
Closed

Conversation

SebiVPS
Copy link
Contributor

@SebiVPS SebiVPS commented Dec 10, 2024

Use named imports instead of barrel importing React. Doing so will result in less code and better readability. The new React docs also use named imports and never import React itself.

To avoid conflicts, we temporarily add the eslint rules in the packages on main. The restrict-import rule will be added in the v8 (next) branch in the eslint-config package, then they will be removed there again.

@SebiVPS SebiVPS requested a review from johnnyomair December 10, 2024 08:08
@SebiVPS SebiVPS self-assigned this Dec 10, 2024
Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint and build docs workflow fail

@SebiVPS SebiVPS closed this Dec 10, 2024
@johnnyomair johnnyomair deleted the remove-react-barrel-imports-docs branch December 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants