Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories: EditDialog behaviour #2925

Closed
wants to merge 3 commits into from
Closed

Conversation

andrearutrecht
Copy link
Contributor

@andrearutrecht andrearutrecht commented Dec 13, 2024

Description

This PR shows EditDialogs behaviour in very specific use cases. It should help to identify and resolve these issues.

The added stories:

  • When EditDialog is combined with a StackPage, the dialog opens above the edit page and prevents interaction. Closing the dialog navigates to the parent page. The structure of the story is the same as in the original project, but the behaviour cannot yet be reproduced.
  • Add custom action buttons to EditDialog: Dialogs often need more than just save and cancel buttons. This does not currently work

Acceptance criteria

  • I have verified if my change requires an example: <!-- Unit test | Demo | Development story | No example needed --->
  • I have verified if my change requires a changeset
  • I have verified if my change requires screenshots/screencasts

Screenshots/screencasts

Before After
Link Link

Open TODOs/questions

  • Add changeset

Further information

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Collaborator

@johnnyomair johnnyomair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you find solutions for these problems with @piotrgulbis?

@andrearutrecht
Copy link
Contributor Author

andrearutrecht commented Dec 18, 2024

Did you find solutions for these problems with @piotrgulbis?

Yes, the tests showed that the issue I faced is in fact not an EditDialog problem. I can solve it within the project. I think this PR can be closed.

@johnnyomair johnnyomair deleted the stories-edit-dialog branch December 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants