Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not equal in enum filter #2930

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix not equal in enum filter #2930

wants to merge 2 commits into from

Conversation

juliawegmayr
Copy link
Contributor

@juliawegmayr juliawegmayr commented Dec 13, 2024 •
edited
Loading

Description

notEqual in EnumFilters was not working due to a wrong condition in filterToMikroOrmQuery function

Acceptance criteria

  • I have verified if my change requires an example: <!-- Unit test | Demo | Development story | No example needed --->
  • I have verified if my change requires a changeset
  • I have verified if my change requires screenshots/screencasts

Screenshots/screencasts

Before:

Screen.Recording.2024-12-13.at.14.20.14.mov

After:

Screen.Recording.2024-12-13.at.14.23.59.mov

Open TODOs/questions

  • Add changeset

Further information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@juliawegmayr juliawegmayr marked this pull request as ready for review December 13, 2024 13:51
@auto-assign auto-assign bot requested a review from johnnyomair December 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnyomair johnnyomair Awaiting requested review from johnnyomair

At least 1 approving review is required to merge this pull request.

Assignees

@juliawegmayr juliawegmayr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juliawegmayr