Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc]: Update default max_num_batch_tokens for chunked prefill #11319

Closed
1 task done
toslunar opened this issue Dec 19, 2024 · 2 comments · Fixed by #11694
Closed
1 task done

[Doc]: Update default max_num_batch_tokens for chunked prefill #11319

toslunar opened this issue Dec 19, 2024 · 2 comments · Fixed by #11694
Labels
documentation Improvements or additions to documentation

Comments

@toslunar
Copy link
Contributor

📚 The doc issue

#10544 only fixed the code. The value in the documentation (https://docs.vllm.ai/en/v0.6.5/usage/performance.html) could be updated, too.

Suggest a potential alternative/fix

No response

Before submitting a new issue...

  • Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.
@toslunar toslunar added the documentation Improvements or additions to documentation label Dec 19, 2024
@simon-mo
Copy link
Collaborator

PR welcomed. Thanks!

@SachinVarghese SachinVarghese mentioned this issue Jan 2, 2025
Merged
@SachinVarghese
Copy link
Contributor

Created PR #11694. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update default max_num_batch_tokens for chunked prefill SachinVarghese/vllm
3 participants
@toslunar @simon-mo @SachinVarghese