Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default max_num_batch_tokens for chunked prefill to 2048 #10544

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Nov 21, 2024

We have seen that 512 is a very conservative value, especially once on H100. Increasing this is 2048 is still a bit conservative but a definite improvement in processing large prefills or throughput.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 21, 2024
Copy link

mergify bot commented Nov 22, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgoin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 22, 2024
@mergify mergify bot removed the needs-rebase label Nov 22, 2024
@youkaichao youkaichao merged commit 02a43f8 into main Nov 23, 2024
47 of 49 checks passed
@youkaichao youkaichao deleted the default-chunked-prefill-2048 branch November 23, 2024 05:14
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants