Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Implement merged input processor for Phi-3-Vision models #10977

Merged
merged 14 commits into from
Dec 9, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 7, 2024

  • Implement merged input processor for Phi-3-Vision models

TODO

  • Expose num_crops and update mm_processor_kwargs test

Copy link

github-actions bot commented Dec 7, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Dec 8, 2024

The model tests and mm_processor_kwargs tests have all passed locally.

@Isotr0py Isotr0py marked this pull request as ready for review December 8, 2024 11:52
vllm/model_executor/models/phi3v.py Outdated Show resolved Hide resolved
vllm/model_executor/models/phi3v.py Outdated Show resolved Hide resolved
@Isotr0py
Copy link
Collaborator Author

Isotr0py commented Dec 8, 2024

BTW, tests/multimodal/test_processor_kwargs.py is failing since we removed input_mapper etc for phi3_v, are there any models that we can migrate the test to?

Update: I decided to migrate the test to use InternVL2 for test, because its max_dynamic_patch is equivalent to num_crops in Phi3v and we probably put it to last to modify. (It doesn't have a hf_processor)

@DarkLight1337
Copy link
Member

I can verify that the model also works on my end. Thanks for helping with the refactoring effort!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 8, 2024 22:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 8, 2024
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
@youkaichao youkaichao disabled auto-merge December 9, 2024 20:54
@youkaichao youkaichao merged commit a811dd6 into vllm-project:main Dec 9, 2024
49 of 51 checks passed
@Isotr0py Isotr0py deleted the phi3v-update branch December 10, 2024 02:21
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants