Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executor][Ray] Change to use general get_node_and_accelerator_ids #11257

Closed
wants to merge 1 commit into from

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Dec 17, 2024

Mainly changes:

  1. This pr uses get_node_and_accelerator_ids instead of get_node_and_gpu_ids for general accelerators.
  2. Each platform maintains its own ray_device_key, making it easier to extend other backends.

FYI, available ray device keys: https://github.com/ray-project/ray/blob/master/python/ray/_private/ray_constants.py#L441

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member

thank you! that's very useful! I will add it to #11256 .

@MengqingCao please also help review that PR, that will be the major one to refactor executors.

@MengqingCao
Copy link
Contributor Author

thank you! that's very useful! I will add it to #11256 .

@MengqingCao please also help review that PR, that will be the major one to refactor executors.

Okay, I'm very happy to review #11256, which is a big and helpful work👍

@MengqingCao
Copy link
Contributor Author

close as being included in #11948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants