Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Restore support for larger block sizes #11259

Conversation

kzawora-intel
Copy link
Contributor

@kzawora-intel kzawora-intel commented Dec 17, 2024

This PR reverts #10938, expands description of block size and adds assertion for CUDA-supported block sizes in CacheConfig.
While GPU kernels might not support block sizes greater than 32, other accelerators do. On HPU, going below block size 128 is very detrimental to performance, and 128 is used there by default.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@kzawora-intel kzawora-intel force-pushed the revert-10938-qian/fix-block-size-default branch from 007a573 to 9059886 Compare December 17, 2024 11:42
@kzawora-intel kzawora-intel changed the title Restore support for larger block sizes [Bugfix] Restore support for larger block sizes Dec 17, 2024
@kzawora-intel kzawora-intel force-pushed the revert-10938-qian/fix-block-size-default branch from ecff947 to c9a38a4 Compare December 17, 2024 12:36
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable and thanks for the clear error for CUDA

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@simon-mo simon-mo merged commit 866fa45 into vllm-project:main Dec 18, 2024
20 of 23 checks passed
SageMoore pushed a commit to neuralmagic/vllm that referenced this pull request Dec 19, 2024
@comaniac
Copy link
Collaborator

Found this PR because I got an error saying block size can only be up to 32 on CUDA. However, I was using larger block sizes with FlashAttention without any issue. Just want to confirm that do we really have this constraint for all use cases on CUDA?

BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants