Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Validate and concatenate image embeddings in MiniCPMVBaseModel #11631

Merged
merged 2 commits into from
Dec 30, 2024
Merged

[Bugfix] Validate and concatenate image embeddings in MiniCPMVBaseModel #11631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c03214d
[Model] Validate and concatenate image embeddings in MiniCPMVBaseModel
whyiug Dec 30, 2024
b2ff893
[Model] Fix type validation for image embeddings in MiniCPMVBaseModel
whyiug Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions vllm/model_executor/models/minicpmv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,12 @@ def _parse_and_validate_inputs(
image_embeds = kwargs.pop("image_embeds", None)

if image_embeds is not None:
if not isinstance(image_embeds, (torch.Tensor, list)):
raise ValueError(f"Incorrect type of image embeds. "
f"Got type: {type(image_embeds)}")
if isinstance(image_embeds, list):
image_embeds = torch.concat(image_embeds)

return MiniCPMVImageEmbeddingInputs(
image_bounds=self._get_image_bounds(input_ids, im_start_id,
im_end_id, slice_start_id,
Expand Down
Loading