-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][V1] Fix molmo text-only inputs #11676
Merged
+123
−42
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5d6b39f
DOne
jeejeelee d2e0840
Add comment
jeejeelee 16efb85
Optimize logic
jeejeelee ef37f8d
Add comments
jeejeelee 9762e8d
format
jeejeelee 85f1fa7
Merge branch 'vllm-project:main' into fix-v1-molmo
jeejeelee 3b0a807
Backup
jeejeelee c824290
Merge branch 'vllm-project:main' into fix-v1-molmo
jeejeelee 86ce64f
Merge branch 'vllm-project:main' into fix-v1-molmo
jeejeelee cc831b6
Fix format
jeejeelee 0f91817
Fix format
jeejeelee e7ea79e
Merge branch 'vllm-project:main' into fix-v1-molmo
jeejeelee 8686011
Fix format
jeejeelee a38c64f
Fix format
jeejeelee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure why this was in the code originally when the AI2 team made the PR to support Molmo on vLLM, but I guess it wasn't an issue back then because it didn't matter on V0 since we didn't use the placeholder ranges for these "dummy" image input indices padded to the prompt token ids.