Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Chore: cruft removal #11724

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[V1] Chore: cruft removal #11724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vllm/entrypoints/llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,8 +225,6 @@ def __init__(
# Logic to switch between engines is done at runtime instead of import
# to avoid import order issues
self.engine_class = self.get_engine_class()

# TODO(rob): enable mp by default (issue with fork vs spawn)
self.llm_engine = self.engine_class.from_engine_args(
engine_args, usage_context=UsageContext.LLM_CLASS)

Expand Down
2 changes: 0 additions & 2 deletions vllm/v1/engine/core_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ class InprocClient(EngineCoreClient):

* pushes EngineCoreRequest directly into the EngineCore
* pulls EngineCoreOutputs by stepping the EngineCore

TODO: support asyncio-mode for debugging.
"""

def __init__(self, *args, **kwargs):
Expand Down
4 changes: 0 additions & 4 deletions vllm/v1/engine/llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ def __init__(
use_cached_outputs: bool = False,
multiprocess_mode: bool = False,
) -> None:

# TODO: Can we avoid this?
self.model_config = vllm_config.model_config

# Tokenizer (+ ensure liveness if running in another process).
Expand Down Expand Up @@ -179,8 +177,6 @@ def step(self) -> List[RequestOutput]:

return request_outputs

# TODO(rob): Can we get rid of these?

def get_model_config(self):
return self.model_config

Expand Down
3 changes: 0 additions & 3 deletions vllm/v1/engine/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ def __init__(
cache_config.enable_prefix_caching
self.mm_hasher = MMHasher()

# TODO: run in an ThreadpoolExecutor or BackgroundProcess.
# This ideally should releases the GIL, so we should not block the
# asyncio loop while this is running.
Comment on lines -52 to -54
Copy link
Member

@ywang96 ywang96 Jan 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep note regardingThreadpool ? or at least put a TODO on if this can be optimized?

def process_inputs(
self,
request_id: str,
Expand Down
Loading