[Hardware][Gaudi][Bugfix] Fix set_forward_context arguments and CI test execution #12014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Konrad Zawora <[email protected]>
kzawora-intel
force-pushed
the
private/kzawora/set_forward_context
branch
from
5403538 to
0f60e48
Compare
github-actions
bot
added
the
ready
youkaichao
reviewed
Jan 14, 2025
|
the test is green now, merging. |
ice-tong
pushed a commit
to ice-tong/vllm
that referenced
this pull request
Jan 18, 2025
…#12014) Signed-off-by: Konrad Zawora <[email protected]> Signed-off-by: ice-tong <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…#12014) Signed-off-by: Konrad Zawora <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…#12014) Signed-off-by: Konrad Zawora <[email protected]>
HwwwwwwwH
pushed a commit
to HwwwwwwwH/vllm
that referenced
this pull request
Jan 22, 2025
…#12014) Signed-off-by: Konrad Zawora <[email protected]> Signed-off-by: hzh <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…#12014) Signed-off-by: Konrad Zawora <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…#12014) Signed-off-by: Konrad Zawora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes HPU crashes introduced in #11967, occuring due to
set_forward_contextbeing set too early, with attn_metadata not containing all the required fields. Additionally, it fixes the bug in CI HPU scripts, where test return code was not taken into account, and it always succeeded. I've also updatedDockerfile.hputo use latest SynapseAI 1.19.1 build with PT 2.5.1, as 1.18.0 release had a bug which may result in overriding test exit code separately.