Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix num_heads value for simple connector when tp enabled #12074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShangmingCai
Copy link
Contributor

@ShangmingCai ShangmingCai commented Jan 15, 2025

This is a bug fix for #11058. The former fix did not handle the head_size properly when tp is enabled.

Let say, if -tp 2 is enabled, we will send the key/value cache with its shape equal to "[num_layer, prompt_token_length, num_key_value_heads, head_size]" in the implementation of #11058. And the "[num_layer, prompt_token_length, num_key_value_heads/2:num_key_value_heads, head_size]" will all be zeros.
image
Currently, the recv side will discard these zeros when calling ops.reshape_and_cache_flash, so it somehow works in the previous version, but we should not send these zeros in the first place.

cc @KuntaiDu

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@ShangmingCai ShangmingCai changed the title [Bugfix] Fix num_heads value for simple connector when tp enabled. [Bugfix] Fix num_heads value for simple connector when tp enabled Jan 15, 2025
@ShangmingCai
Copy link
Contributor Author

@KuntaiDu @youkaichao Please review this bugfix if you still have bandwidth.

Copy link
Collaborator

@KuntaiDu KuntaiDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@KuntaiDu KuntaiDu enabled auto-merge (squash) January 18, 2025 13:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants