[Bugfix] Fix num_heads value for simple connector when tp enabled #12074
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for #11058. The former fix did not handle the head_size properly when tp is enabled.
Let say, if
-tp 2
is enabled, we will send the key/value cache with its shape equal to "[num_layer, prompt_token_length, num_key_value_heads, head_size]
" in the implementation of #11058. And the "[num_layer, prompt_token_length, num_key_value_heads/2:num_key_value_heads, head_size]
" will all be zeros.Currently, the recv side will discard these zeros when calling
ops.reshape_and_cache_flash
, so it somehow works in the previous version, but we should not send these zeros in the first place.cc @KuntaiDu