[Bugfix] Fix a path bug in disaggregated prefill example script. #12121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kuntai Du <[email protected]>
Signed-off-by: Kuntai Du <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
comaniac
approved these changes
Jan 16, 2025
|
This PR only touches example script so the test fail is irrelevant. |
ice-tong
pushed a commit
to ice-tong/vllm
that referenced
this pull request
Jan 18, 2025
…m-project#12121) Signed-off-by: Kuntai Du <[email protected]> Signed-off-by: ice-tong <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…m-project#12121) Signed-off-by: Kuntai Du <[email protected]>
joennlae
pushed a commit
to 44ai-labs/vllm
that referenced
this pull request
Jan 19, 2025
…m-project#12121) Signed-off-by: Kuntai Du <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…m-project#12121) Signed-off-by: Kuntai Du <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
abmfy
pushed a commit
to abmfy/vllm-flashinfer
that referenced
this pull request
Jan 24, 2025
…m-project#12121) Signed-off-by: Kuntai Du <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #11923 , the path of disaggregated prefill example script moved into
online_servingfolder. Update the example script to make sure it is functional.Also add
set -xeto make sure it crashes instead of failing silently when error occurred in the script.