Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Revert PR #11435: Fix issues in CPU build Dockerfile. Fixes #9182 #12135

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Jan 17, 2025

This reverts commit 409475a.

See discussions in #11435. This is no longer needed if we configure podman correctly (ref: containers/buildah#4184).

cc @dtrifiro

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 17, 2025
@terrytangyuan
Copy link
Contributor Author

cc @DarkLight1337

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 17, 2025 03:36
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 17, 2025
@terrytangyuan
Copy link
Contributor Author

@DarkLight1337 Thanks. Looks like we might need to re-run

@youkaichao youkaichao disabled auto-merge January 17, 2025 04:53
@youkaichao youkaichao merged commit b8bfa46 into vllm-project:main Jan 17, 2025
87 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants