Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD][CI/Build][Bugfix] updated pytorch stale wheel path by using stable wheel #12172

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

hongxiayang
Copy link
Collaborator

@hongxiayang hongxiayang commented Jan 17, 2025

FIX #12066

This PR is to replace the stale nightly wheel path for ROCm 6.2 pytorch with the stable pytorch wheel.
When the Dockerfile.rocm was previously upgraded to ROCm 6.2, the stable wheel does not exist yet for ROCm 6.2 in pytorch, therefore a nightly wheel path was used.
Since the current stable wheel is available, we replace it with the stable wheel path.

The reporter of the issue has confirmed it worked.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added ci/build documentation Improvements or additions to documentation labels Jan 17, 2025
@hongxiayang
Copy link
Collaborator Author

/ready

@hongxiayang hongxiayang added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 17, 2025
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@youkaichao youkaichao merged commit c09503d into vllm-project:main Jan 18, 2025
87 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Installation][build][docker]: rocm Dockerfile pinned to stale python torch nightly wheel builds
2 participants