Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked-prefill-doc-syntax #4603

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

simon-mo
Copy link
Collaborator

@simon-mo simon-mo commented May 5, 2024

@simon-mo simon-mo requested a review from rkooo567 May 5, 2024 07:25
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look at the built doc and left some comments :) (mostly for @rkooo567)

docs/source/models/performance.rst Outdated Show resolved Hide resolved
docs/source/models/performance.rst Outdated Show resolved Hide resolved
docs/source/models/performance.rst Outdated Show resolved Hide resolved
docs/source/models/performance.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR! @ywang96 I agreed with your comment in general. @simon-mo would you like me to push changes or will you address it?

docs/source/models/performance.rst Outdated Show resolved Hide resolved
@simon-mo
Copy link
Collaborator Author

simon-mo commented May 6, 2024

@rkooo567 plz push

@rkooo567
Copy link
Collaborator

rkooo567 commented May 8, 2024

ETA tmrw!

@rkooo567
Copy link
Collaborator

rkooo567 commented May 9, 2024

comments addressed

@rkooo567 rkooo567 merged commit 51d4094 into vllm-project:main May 10, 2024
59 checks passed
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request May 19, 2024
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request May 21, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants