Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Use vllm-flash-attn instead of flash-attn #4686

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

WoosukKwon
Copy link
Collaborator

This PR is to use the pre-built vllm-flash-attn wheel instead of the original flash-attn.

@WoosukKwon WoosukKwon requested a review from LiuXiaoxuanPKU May 8, 2024 16:01
Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WoosukKwon WoosukKwon merged commit 89579a2 into main May 8, 2024
24 of 25 checks passed
@WoosukKwon WoosukKwon deleted the vllm-flash-attn branch May 8, 2024 20:15
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 9, 2024
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request May 19, 2024
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request May 21, 2024
@maxin9966
Copy link

Thank you very much. By the way, does vllm-flash-attn support Turing architecture GPUs like the 2080ti? I recall that the Turing GPU supports flash-attn1.

@CYang0515
Copy link

I‘m confused. What is the difference between vllm-flash-attn and flash-attn,why use vllm-flash-attn instead of flash attn?

@CYang0515
Copy link

Currently, vllm-flash-attn only supports cuda12.1. Should I recompile it from source code for the other cuda or torch version?

Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants