[Misc] Set block size at initialization & Fix test_model_runner #4705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the block size to
ModelRunner
at its initialization time, instead of setting it lazily. Currently, we don't have any reason to set this value lazily, since it is configured by the user argument.Also, the PR fixes the abuse of
ModelRunner
intest_model_runner
where basicallyModelRunner
was initialized withNone
arguments.