-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix PP for ChatGLM and Molmo, and weight loading for Qwen2.5-Math-RM #9422
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Sorry for breaking your code! @lixiaolx can you test out this PR and see if you can load Qwen/Qwen2.5-Math-RM-72B now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLM4-V
and Molmo
PP tests all passed on my devices. LGTM once Qwen2-RM is also confirmed to work.
@DarkLight1337 , I tried adding lm_head filtering to the model.py file of qwen_rm. add print code in |
Can you add print statements inside |
Any update? Otherwise, I'll merge this PR first and fix the model in another PR. |
I think I fixed the problem, so I'm going to merge this now. Please tell me and share the logs (set the environment variable |
Signed-off-by: Alvant <[email protected]>
Signed-off-by: Erkin Sagiroglu <[email protected]>
Signed-off-by: Shanshan Wang <[email protected]>
Signed-off-by: Shanshan Wang <[email protected]>
Signed-off-by: qishuai <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Signed-off-by: Maxime Fournioux <[email protected]>
Signed-off-by: Tyler Michael Smith <[email protected]>
#9242 accidentally removed PP support from ChatGLM. On the other hand,
MolmoModel
already supports PP but the top-levelMolmoForCausalLM
does not. This PR fixes both of these issues.The input processors of these models and Qwen2-VL have also been cleaned up a bit.
Also fixes #9090 (comment)